Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils_net: also check ip for host up nic #3982

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

utils_net: also check ip for host up nic #3982

wants to merge 1 commit into from

Conversation

yanqzhan
Copy link
Contributor

When create linux bridge or macvtap for guest interface to use, there maybe many UP state host nic, but only the ones with ip can work.

@yanqzhan
utils_net: also check ip for host up nic
745fd8d 
When create linux bridge or macvtap for guest interface to use,
there maybe many UP state host nic, but only the ones with ip can
work.

Signed-off-by: Yanqiu Zhang <[email protected]>
@yanqzhan
Copy link
Contributor Author

1.virtual_network.iface_bridge.default.shared_physical_network
Before:
TestFail: Failed to create linux bridge on the host. Status: 1 Stdout: Command 'tmux -c "ip link add name test_br0 type bridge; ip link set eno8303 up; ip link set eno8303 master test_br0; ip link set test_br0 up; pkill dhclient; sleep 6; dhclient test_br0; ifconfig eno8303 0"' failed.stdout: b''stderr: b'grep: /etc/sysconfig/network-scripts/ifcfg-: No such file or directory\ngrep: /etc/sysconfig/network-scripts/ifcfg-: No such file or directory\ngrep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory\n'additional_info: None
After:
(1/1) type_specific.io-github-autotest-libvirt.virtual_network.iface_bridge.default.shared_physical_network: PASS (255.80 s)

  1. virtual_network.iface_network.net_macvtap.net_private
    Before:
    TestFail: Guest has invalid ip address
    After:
    (1/1) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_private: PASS (41.86 s)

@yanqzhan
Copy link
Contributor Author

Rerun 14 cases of invalid ip failures in libvirt-RHEL-9.5-runtest-x86_64-function-virtual_networks/47 PASS:
(1/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.default_test: STARTED
(1/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.default_test: PASS (40.82 s)
(2/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.multi_guests: STARTED
(2/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.multi_guests: PASS (85.76 s)
(3/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.exist_macvtap: STARTED
(3/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_bridge.exist_macvtap: PASS (47.53 s)
(4/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_passthrough: STARTED
(4/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_passthrough: PASS (44.80 s)
(5/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_private: STARTED
(5/5) type_specific.io-github-autotest-libvirt.virtual_network.iface_network.net_macvtap.net_private: PASS (44.94 s)
JOB LOG : /var/log/avocado/job-results/job-2024-08-28T09.18-ff5b3d9/job.log
(1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_bridge: STARTED
(1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_bridge: PASS (330.28 s)
(2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_vepa: STARTED
(2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_vepa: PASS (181.98 s)
(3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_private: STARTED
(3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_vhost.mode_private: PASS (186.40 s)
(4/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_bridge: STARTED
(4/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_bridge: PASS (332.55 s)
(5/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_vepa: STARTED
(5/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_vepa: PASS (184.77 s)
(6/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_private: STARTED
(6/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.default.driver_qemu.mode_private: PASS (185.98 s)
(7/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_bridge: STARTED
(7/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_bridge: PASS (329.92 s)
(8/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_vepa: STARTED
(8/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_vepa: PASS (185.80 s)
(9/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_private: STARTED
(9/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_macvtap.multiqueue.driver_vhost.mode_private: PASS (186.71 s)

@yanqzhan yanqzhan marked this pull request as draft August 29, 2024 02:30
@yanqzhan
Copy link
Contributor Author

haijiao will push a new pr with another good way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yanqzhan